Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor mutable-state log fix #5776

Conversation

davidporter-id-au
Copy link
Member

What changed?
Some reasonable feedback on a diff I didn't address before autolanding, so landing here. Just making the logs both slightly more defensive and returning early where possible.

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@davidporter-id-au davidporter-id-au merged commit 646ac32 into cadence-workflow:master Mar 11, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e2f31-f624-46df-bca7-f24f826c6a82

Details

  • 9 of 15 (60.0%) changed or added relevant lines in 1 file are covered.
  • 49 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 64.1%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/execution/mutable_state_builder.go 9 15 60.0%
Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.01%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
service/matching/taskListManager.go 2 79.7%
service/history/queue/timer_queue_processor_base.go 3 77.82%
common/persistence/statsComputer.go 3 94.64%
service/frontend/wrappers/metered/metered.go 4 65.5%
service/history/execution/mutable_state_task_refresher.go 7 66.46%
service/history/execution/mutable_state_builder.go 12 70.3%
common/persistence/sql/workflow_state_maps.go 12 81.25%
Totals Coverage Status
Change from base Build 018e2ebe-807b-4e78-97fa-f22e8f0a52db: 0.02%
Covered Lines: 93452
Relevant Lines: 145791

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants