Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of tests for archivalConfigStateMachine in common/domain #5778

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Added tests for archivalConfigStateMachine in common/domain

Why?
To increase test coverage

How did you test it?
Unit Tests

Potential risks
No risks, as it only contains tests not calling real db instances etc.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #5778 (a15ceef) into master (7ef6c99) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef6c99...a15ceef. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e3163-8300-4a06-82ea-df00ae37e094

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 122 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.007%) to 64.118%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/task/transfer_active_task_executor.go 2 72.51%
common/persistence/executionManager.go 2 78.59%
service/matching/taskListManager.go 2 80.2%
service/history/execution/mutable_state_util.go 2 78.48%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 71.41%
service/history/task/transfer_standby_task_executor.go 4 87.01%
common/task/fifo_task_scheduler.go 5 84.54%
common/persistence/statsComputer.go 5 94.64%
Totals Coverage Status
Change from base Build 018e2fd9-a00f-486a-badd-cbc5210ae61c: -0.007%
Covered Lines: 93479
Relevant Lines: 145791

💛 - Coveralls

@abhishekj720 abhishekj720 merged commit b495dcd into cadence-workflow:master Mar 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants