Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable sql unit test #5779

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

Shaddoll
Copy link
Member

What changed?
Re-enable sql unit test

Why?
The unit tests in sql package was disabled unexpectedly due to a bug we introduced.

How did you test it?
manually verified locally

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll merged commit bc0df2d into cadence-workflow:master Mar 12, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e33c5-52aa-447e-951e-4b1d8e76483e

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 79 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.7%) to 64.863%

Files with Coverage Reduction New Missed Lines %
common/task/parallel_task_processor.go 2 93.06%
service/history/task/transfer_active_task_executor.go 2 72.38%
common/persistence/executionManager.go 2 78.59%
service/matching/matcher.go 2 90.72%
common/task/fifo_task_scheduler.go 3 82.47%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/worker/scanner/executor/runq.go 3 85.48%
service/history/task/transfer_standby_task_executor.go 4 87.63%
service/history/task/fetcher.go 4 85.05%
common/persistence/statsComputer.go 8 93.57%
Totals Coverage Status
Change from base Build 018e3365-94dc-40ce-89f9-8fe019e7ad59: 0.7%
Covered Lines: 94564
Relevant Lines: 145791

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants