Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retryable error for workflow rate limits in task processing #5782

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

sankari165
Copy link
Member

What changed?
New error that will be introduced when task processing requests are ratelimited

Why?
Task processing limits will be ratelimited based on wf-id based rate limits and needs to be retried

How did you test it?
Unit tests

Potential risks
error is still not in use

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #5782 (18be97f) into master (2a30afd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 18be97f differs from pull request most recent head 2b9fa3d. Consider uploading reports for the commit 2b9fa3d to get more accurate results

Additional details and impacted files
Files Coverage Δ
service/history/task/task.go 79.02% <100.00%> (+2.17%) ⬆️
...vice/history/task/transfer_active_task_executor.go 68.25% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a30afd...2b9fa3d. Read the comment docs.

service/history/task/task_test.go Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 15, 2024

Pull Request Test Coverage Report for Build 018e4149-16db-4df5-bc3b-e70de5ad3321

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 72 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.02%) to 64.856%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/parallel_task_processor.go 2 93.06%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/frontend/api/handler.go 2 62.05%
service/matching/db.go 2 73.23%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/taskListManager.go 2 79.7%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
Totals Coverage Status
Change from base Build 018e3f53-e7d7-4032-837c-2935dd51ab5f: -0.02%
Covered Lines: 94545
Relevant Lines: 145777

💛 - Coveralls

@sankari165 sankari165 enabled auto-merge (squash) March 15, 2024 08:44
@sankari165 sankari165 merged commit 38930fa into cadence-workflow:master Mar 15, 2024
17 of 18 checks passed
@sankari165 sankari165 deleted the CDNC-6161 branch March 15, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants