Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot fix for unit test cases that might cause a failure #5787

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

bowenxia
Copy link
Contributor

@bowenxia bowenxia commented Mar 14, 2024

What changed?
Change the error assertion from "equal to err.Error()" to "equal to error"

Why?
hot fix for unit test cases that might cause a failure

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #5787 (5318469) into master (3c7c303) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 5318469 differs from pull request most recent head 011b67e. Consider uploading reports for the commit 011b67e to get more accurate results

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7c303...011b67e. Read the comment docs.

@bowenxia bowenxia merged commit 51f592f into master Mar 14, 2024
19 checks passed
@bowenxia bowenxia deleted the xbowen_pinot_visibility_store_test_hotfix branch March 14, 2024 18:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e3e0b-2d0f-4c90-a1a8-f2e712f1bb37

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 73 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.008%) to 64.858%

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/parallel_task_processor.go 2 93.06%
common/peerprovider/ringpopprovider/config.go 2 81.58%
service/matching/db.go 2 73.23%
service/history/execution/mutable_state_builder.go 2 70.3%
service/history/task/fetcher.go 2 85.05%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.18%
service/history/queue/timer_gate.go 3 95.83%
Totals Coverage Status
Change from base Build 018e38e2-422c-460d-92ea-2946554c16c2: 0.008%
Covered Lines: 94537
Relevant Lines: 145760

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants