Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unit test for function in mapper-thrift-configstore file #5789

Conversation

d-vignesh
Copy link
Contributor

@d-vignesh d-vignesh commented Mar 15, 2024

What changed?
Added unit tests for functions under mapper/thrift/configStore.go file

Why?
To improve test coverage.

How did you test it?
Locally using go test.

Potential risks

Release notes

Documentation Changes

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2024

CLA assistant check
All committers have signed the CLA.

import (
"testing"

"github.com/stretchr/testify/assert"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files need the license thing at the top and imports follow certain ordering. if you run make fmt it should take care of these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the file. Can you please check once.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to run
make fmt.
We use gci to ensure imports sort/grouping/order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah added the license info and ran make fmt command also.

Copy link
Member

@taylanisikdemir taylanisikdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to coverage improvement!

@d-vignesh
Copy link
Contributor Author

Hi team, the CI pipeline seems to be failing with the last push when i tried rebasing with the master, not able to get any error logs from the pipeline, can you please check what is the issue

@d-vignesh
Copy link
Contributor Author

d-vignesh commented Mar 18, 2024

Hi team, i would like to write the unit tests for the remaining files in the mapper/thrift directory. Can you please let me know if i can follow the same conventions that i followed in this PR.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #5789 (7504a03) into master (d60041f) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60041f...7504a03. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e53c9-396b-4cd8-821f-9b09231fb00c

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.08%) to 65.002%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/shard/context.go 2 66.7%
common/task/parallel_task_processor.go 2 93.06%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/util.go 2 91.69%
service/matching/taskListManager.go 2 80.2%
common/membership/hashring.go 2 82.23%
service/history/task/fetcher.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
Totals Coverage Status
Change from base Build 018e53aa-bc8b-40e2-9d7c-012f8da56b45: 0.08%
Covered Lines: 94885
Relevant Lines: 145972

💛 - Coveralls

@Shaddoll Shaddoll merged commit c521fa3 into cadence-workflow:master Mar 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants