Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for cassandra SelectWorkflowExecution #5792

Conversation

taylanisikdemir
Copy link
Member

What changed?

  • Added unit tests for cassandra plugin's SelectWorkflowExecution
  • Minor refactoring on other test cases based on feedback

Why?

  • Improve coverage

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #5792 (360a1ea) into master (3091e41) will increase coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3091e41...360a1ea. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e4fc1-ee35-4870-9cd7-4fcaab7089ed

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.04%) to 64.919%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/peerprovider/ringpopprovider/config.go 2 81.58%
service/history/task/transfer_active_task_executor.go 2 72.51%
common/membership/hashring.go 2 82.23%
common/persistence/statsComputer.go 3 93.57%
service/history/queue/timer_queue_processor_base.go 4 77.62%
Totals Coverage Status
Change from base Build 018e43c7-e893-4c40-a63b-442d9dceb207: 0.04%
Covered Lines: 94761
Relevant Lines: 145968

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit 4ebaaa2 into cadence-workflow:master Mar 18, 2024
20 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/workflows_test_select_wf_exec branch March 18, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants