Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade apache thrift to v.0.17.0 #5814

Merged

Conversation

3vilhamster
Copy link
Member

@3vilhamster 3vilhamster commented Mar 25, 2024

What changed?
I'm upgrading Apache Thrift to a recent version. The old replace was caused by monorepo/ringpop lock on the ancient version. It was removed from Monorepo, so we no longer require a lock.

Why?
Remove unsupported ancient version lock.

How did you test it?
Verified local with xdc server setup

./cadence-server --config config --zone xdc --env development_xdc_cluster0 start
./cadence-server --config config --zone xdc --env development_xdc_cluster1 start
./cadence-server --config config --zone xdc --env development_xdc_cluster2 start

Verified inside Uber without issues on staging environments.

Potential risks
None expected. Thrift is binary backward compatible, but they updated the interface with context-aware calls, so the service should fail at compile time.

Release notes
Update apache/thrift to 0.17.0

Documentation Changes

@3vilhamster 3vilhamster changed the title Upgrade apache thrift to a moder version Upgrade apache thrift to v.0.17.0 Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #5814 (5733408) into master (5052d08) will decrease coverage by 0.26%.
The diff coverage is n/a.

❗ Current head 5733408 differs from pull request most recent head c949b66. Consider uploading reports for the commit c949b66 to get more accurate results

Additional details and impacted files

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5052d08...c949b66. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 25, 2024

Pull Request Test Coverage Report for Build 018f0f68-0b9c-4731-bcba-215b5c3a373f

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.697%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/frontend/api/handler.go 2 61.92%
service/history/task/transfer_active_task_executor.go 2 72.72%
service/matching/taskListManager.go 2 80.4%
service/history/queue/timer_gate.go 3 95.83%
service/history/task/fetcher.go 3 86.6%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/matching/matcher.go 4 90.72%
service/history/task/transfer_standby_task_executor.go 6 86.63%
Totals Coverage Status
Change from base Build 018f0ea7-c543-4b66-b97e-6fe62553d2d7: 0.03%
Covered Lines: 99150
Relevant Lines: 146462

💛 - Coveralls

Copy link
Member

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good luck :salut:

@3vilhamster 3vilhamster enabled auto-merge (squash) April 24, 2024 10:50
@3vilhamster 3vilhamster merged commit 877d180 into cadence-workflow:master Apr 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants