-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade apache thrift to v.0.17.0 #5814
Upgrade apache thrift to v.0.17.0 #5814
Conversation
Codecov Report
Additional details and impacted filessee 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018f0f68-0b9c-4731-bcba-215b5c3a373fDetails
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good luck :salut:
What changed?
I'm upgrading Apache Thrift to a recent version. The old replace was caused by monorepo/ringpop lock on the ancient version. It was removed from Monorepo, so we no longer require a lock.
Why?
Remove unsupported ancient version lock.
How did you test it?
Verified local with xdc server setup
Verified inside Uber without issues on staging environments.
Potential risks
None expected. Thrift is binary backward compatible, but they updated the interface with context-aware calls, so the service should fail at compile time.
Release notes
Update apache/thrift to 0.17.0
Documentation Changes