Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of test for TestHandler_UpdateAsyncWorkflowConfiguration #5892

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Test for UpdateAsyncWorkflowConfiguraton

Why?
As part of code coverage week

How did you test it?
Unit test

Potential risks
No risk

@coveralls
Copy link

coveralls commented Apr 8, 2024

Pull Request Test Coverage Report for Build 018fe03a-363d-48ae-bb96-c7900c84a62b

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.372%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
service/history/task/transfer_active_task_executor.go 2 72.7%
common/membership/hashring.go 2 84.69%
service/history/task/transfer_standby_task_executor.go 4 86.19%
service/history/task/fetcher.go 4 85.05%
common/task/fifo_task_scheduler.go 7 80.41%
Totals Coverage Status
Change from base Build 018ec2d0-2d55-4385-9005-feae08321986: 0.03%
Covered Lines: 98208
Relevant Lines: 145769

💛 - Coveralls

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.30%. Comparing base (65c4017) to head (ae95e60).
Report is 163 commits behind head on master.

Additional details and impacted files

see 215 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c4017...ae95e60. Read the comment docs.

@agautam478 agautam478 merged commit 84ab621 into cadence-workflow:master Jun 3, 2024
20 checks passed
@abhishekj720 abhishekj720 deleted the testh3 branch June 4, 2024 19:18
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…dence-workflow#5892)

* Test for UpdateAsyncWorkflowConfiguraton in common/domain

* used assert instead of require

* Added test for AsyncWorkflow Update in common/domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants