Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for ReadHistoryBranch #5899

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Apr 10, 2024

What changed?
Add tests for ReadHistoryBranch

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Merging #5899 (a769f0c) into master (1fd00b5) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd00b5...a769f0c. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 10, 2024

Pull Request Test Coverage Report for Build 018ef572-b3be-461b-9daf-b84bb462de14

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 65 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.005%) to 67.589%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/frontend/api/handler.go 2 62.04%
service/matching/db.go 2 73.23%
service/history/queue/transfer_queue_processor.go 2 57.17%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.46%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/task/task_util.go 4 69.43%
common/task/fifo_task_scheduler.go 5 84.54%
Totals Coverage Status
Change from base Build 018ef47c-7ef1-4ce1-b4c9-3fa25bfb5bee: -0.005%
Covered Lines: 98976
Relevant Lines: 146438

💛 - Coveralls

@jakobht jakobht force-pushed the test_nosql_history_storage_ReadHistoryBranch branch from 4381925 to 9c33b9c Compare April 19, 2024 08:21
@jakobht jakobht force-pushed the test_nosql_history_storage_ReadHistoryBranch branch from 9c33b9c to a769f0c Compare April 19, 2024 08:21
@jakobht jakobht merged commit cc0805f into cadence-workflow:master Apr 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants