wire replicator transmission to domain APIs #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
force-pushed
the
replicate-domain-done
branch
from
612e1a6 to
69c846f
Compare
samarabbas
approved these changes
Mar 2, 2018
service/frontend/handler.go
Outdated
| @@ -117,6 +124,8 @@ func NewWorkflowHandler( | |||
| hSerializerFactory: persistence.NewHistorySerializerFactory(), | |||
| domainCache: cache.NewDomainCache(metadataMgr, sVice.GetLogger()), | |||
| rateLimiter: common.NewTokenBucket(config.RPS, common.NewRealTimeSource()), | |||
| kafkaProducer: kafkaProducer, | |||
There was a problem hiding this comment.
Let's not use any Kafka naming at this layer.
There was a problem hiding this comment.
reduced to just the domainReplicator dependency
| // handleDomainReplicationTask handle the domain replication task | ||
| func (domainReplicator *domainReplicatorImpl) HandleReceiveTask(task *replicator.DomainTaskAttributes) error { | ||
| // HandleTransmissionTask handle transmission of the domain replication task | ||
| func (domainReplicator *domainReplicatorImpl) HandleTransmissionTask(kafka messaging.Producer, domainOperation replicator.DomainOperation, |
There was a problem hiding this comment.
Let's move this logic into a separate component which lives within frontend.
wxing1292
force-pushed
the
replicate-domain-done
branch
from
1095015 to
63125f3
Compare
wxing1292
force-pushed
the
replicate-domain-done
branch
from
63125f3 to
0e1d962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #569