-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memo in pinot #5902
Add memo in pinot #5902
Conversation
Codecov Report
Additional details and impacted files
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
What changed?
Add memo in pinot:
When write, add memo into search attribute
When read, get memo from search attribute and cleanup that field
NOTE: don't merge it until our customer test it locally
Why?
memo was stored in ES but can't be indexed(not in ES schema). We made the pinot schemas according to ES's schema, so we thought that we did't need memo in Pinot, but one customer was complaining about that.
How did you test it?
unit test
Also tested manually at local
Potential risks
not risk since Memo is not a functional attribute.
Release notes
Documentation Changes