Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for common/persistence/retryer.go #5911

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

natemort
Copy link
Member

What changed?

  • Added test coverage for common/persistence/retryer.go

Why?
Improving code coverage

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

package persistence

import (
"context"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make fmt

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #5911 (1eb3724) into master (86a5454) will increase coverage by 0.09%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 1eb3724 differs from pull request most recent head c9273cc. Consider uploading reports for the commit c9273cc to get more accurate results

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0661b7...c9273cc. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 17, 2024

Pull Request Test Coverage Report for Build 018eede6-8e8e-4576-aba9-cb62a8be9885

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 71 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.05%) to 67.453%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 83.55%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/execution/mutable_state_util.go 2 78.52%
common/membership/hashring.go 2 84.69%
common/persistence/historyManager.go 2 66.67%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/statsComputer.go 3 96.07%
service/history/task/transfer_standby_task_executor.go 4 86.19%
service/history/task/fetcher.go 4 85.05%
Totals Coverage Status
Change from base Build 018eedc4-642b-49ce-be74-b8649f645074: 0.05%
Covered Lines: 98729
Relevant Lines: 146368

💛 - Coveralls

@natemort natemort force-pushed the natemort/retryer branch 2 times, most recently from 091f43a to 1eb3724 Compare April 17, 2024 20:29
@natemort natemort enabled auto-merge (squash) April 17, 2024 21:11
@natemort natemort merged commit 27d99b9 into cadence-workflow:master Apr 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants