Adding tests for nosqlQueueStore #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
Codecov Report
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This first diff is around newNoSQLQueueStore()
Now it is 94% covered There are still some edge-cases to cover, will address this in the next PR among with small test restructuring: I want to combine some tests under t.Run() and re-use the common initialisation this way.
dkrotx
force-pushed
the
nosql_queue_store_test
branch
from
7eefc67
to
e3036c5
Compare
Pull Request Test Coverage Report for Build 018f0604-fb84-46a1-90d8-d706591f2dc2Details
💛 - Coveralls |
jakobht
reviewed
Apr 22, 2024
jakobht
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first diff is around newNoSQLQueueStore()
unit tests
code coverage for nosql_queue_store.go
make test
none