-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add double read for latency comparison for Pinot Migration #5927
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to understand one piece of intent, rest looks good
What changed?
Added a double-read flipr config in pinot_visibility_triple_manager
Using go routines to avoid breaking the normal read flow and log the shadow read errors
Why?
We need this to do a latency comparison for Pinot Migration. And we don't want the secondary read to influence the main data flow, thus we need to use concurrency to make the 2 read actions run in the same time.
How did you test it?
Unit test
Potential risks
null
Release notes
Documentation Changes