Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the error to DomainNotActive for Deprecated domains #5929

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

abhishekj720
Copy link
Contributor

@abhishekj720 abhishekj720 commented Apr 23, 2024

What changed?
As part of oncall fix causing muttley service side error, we think the code is breaking because of misclassified error as it see sprintf error as cadence causing issue, but in real it is not.

I think we have to return errors from below for poll for DecisionTask.

Pasted Graphic

Why?
To fix the misclassified error.

How did you test it?
Uni test

Potential risks
Added change to avoid muttley service SLA mess

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #5929 (8687fe9) into master (3db7157) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
...ice/frontend/wrappers/clusterredirection/policy.go 75.00% <100.00%> (+2.63%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db7157...8687fe9. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f08a6-5e98-4985-84e8-e756b43a7bb8

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • 36 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.02%) to 67.683%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/matching/taskGC.go 1 97.37%
common/persistence/execution_manager.go 2 83.74%
common/task/fifo_task_scheduler.go 2 84.54%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/statsComputer.go 2 97.14%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/task/fetcher.go 3 86.6%
tools/cli/admin_db_decode_thrift.go 4 67.95%
service/matching/db.go 8 74.8%
Totals Coverage Status
Change from base Build 018f0624-8017-4517-a93c-99d1ed38a3b0: 0.02%
Covered Lines: 99121
Relevant Lines: 146448

💛 - Coveralls

@davidporter-id-au
Copy link
Member

this isn't for crashes, it's for a misclassified error making a bit of a mess of the SLA

@davidporter-id-au
Copy link
Member

Before merging do you mind correcting the description: Nothing's crashing here

@abhishekj720 abhishekj720 merged commit c76970e into cadence-workflow:master Apr 23, 2024
20 checks passed
@abhishekj720 abhishekj720 deleted the oncallfix-2 branch April 23, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants