Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when pass close status as an integar string #5935

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix bug when pass close status as an integar string #5935

merged 3 commits into from
Apr 23, 2024

Conversation

neil-xie
Copy link
Member

What changed?
Currently it will directly pass the string to Pinot which can cause query failure

Why?
Bug fix

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f0cbc-160f-4f6f-95a7-5cf59e88a2c7

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 42 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.02%) to 67.662%
Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
service/history/task/transfer_standby_task_executor.go 2 87.04%
common/util.go 2 91.78%
service/matching/taskListManager.go 2 79.9%
common/persistence/statsComputer.go 3 96.07%
service/history/task/fetcher.go 3 85.57%
common/task/fifo_task_scheduler.go 5 82.47%
service/history/execution/mutable_state_task_refresher.go 24 56.65%
Totals Coverage Status
Change from base Build 018f0ca3-ba54-45ef-be44-e3c1a63506e3: -0.02%
Covered Lines: 99093
Relevant Lines: 146453
💛 - Coveralls

ibarrajo
ibarrajo approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@ibarrajo ibarrajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@neil-xie neil-xie merged commit fb26a4c into cadence-workflow:master Apr 23, 2024
18 checks passed
@neil-xie neil-xie deleted the cdnc_8648 branch April 23, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibarrajo ibarrajo ibarrajo approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neil-xie @coveralls @ibarrajo