Fix slice reuse in cassandra/domain.go #5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
natemort
force-pushed
the
async
branch
2 times, most recently
from
b318d8e
to
4fef375
Compare
taylanisikdemir
approved these changes
Apr 24, 2024
| @@ -410,6 +410,10 @@ func (db *cdb) SelectAllDomains( | |||
| replicationClusters = []map[string]interface{}{} | |||
| badBinariesData = []byte("") | |||
| badBinariesDataEncoding = "" | |||
| isolationGroups = []byte("") | |||
| isolationGroupsEncoding = "" | |||
| asyncWFConfigData = []byte("") | |||
There was a problem hiding this comment.
asyncWFConfigData = nil would also do the job. not sure why the byte arrays were reset like this before.
While reading domains from Cassandra the isolationGroups and asncWFConfigData are not properly reset for each row. This can result in the same backing array being reused across multiple rows, resulting in an incorrect or corrupted value being read. Notably this is used for the domain cache, so any operation relying on it may be unable to get the correct values of these fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Reset the fields for isolationGroups and asyncWFConfigData after each row.
While reading domains from Cassandra the isolationGroups and asncWFConfigData are not properly reset for each row. This can result in the same backing array being reused across multiple rows, resulting in an incorrect or corrupted value being read.
Why?
Fixes a bug where the domain cache contains the wrong async wf config data and is unable to trigger an async workflow despite it being enabled for that ddomain.
How did you test it?
Potential risks
Release notes
Documentation Changes