We now wait 10 seconds before we start returning shard closed errors, also stop retrying on shard closed errors #5938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Shaddoll
reviewed
Apr 25, 2024
Shaddoll
approved these changes
Apr 25, 2024
taylanisikdemir
approved these changes
Apr 26, 2024
jakobht
changed the title
Shard closing is not an unexpected state, so we should not emit error logs and metrics on this. However if we stay in a state where a closed shard keeps getting requests. Then we should start emitting error logs and metrics.
This reverts commit f2687b6.
… information on when the task timed out as well
jakobht
force-pushed
the
shardClosedInvestigation
branch
from
0b95a40
to
f313fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Deleted unreachable instances of the guard. These were introduced in Update shard context to reduce DB calls for closed shards #4547 when the checks were in a loop that was accessing the DB, which was able to change the shard's closed state in each iterationWhy?
Shard closing is not an unexpected state, so we should not emit error logs and metrics for this.
If we stay in a state where a closed shard keeps getting requests, then we should start emitting error logs and metrics, so we wait 10 seconds, and if we still see requests then we start emitting the metrics.
All the guard testing and deleting is necessary to make the new line coverage check happy.
How did you test it?
Tested with unit tests and by deploying to staging. The deployment shows we can now do restarts without seeing these errors.
Potential risks
This does change some relatively core task processing logic, however the main change is on how the error states are communicated. The main flow is not touched.
Release notes
Documentation Changes