Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for GetAllHistoryTreeBranches #5944

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Apr 26, 2024

What changed?
Added tests for GetAllHistoryTreeBranches

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.76%. Comparing base (85f21d9) to head (a709d27).
Report is 1 commits behind head on master.

❗ Current head a709d27 differs from pull request most recent head 0f210b8. Consider uploading reports for the commit 0f210b8 to get more accurate results

Additional details and impacted files

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c669c4f...0f210b8. Read the comment docs.

@jakobht jakobht force-pushed the test_nosql_history_storage_GetAllHistoryTreeBranches branch from df33e99 to a709d27 Compare April 29, 2024 07:25
@jakobht jakobht enabled auto-merge (squash) April 29, 2024 12:13
@jakobht jakobht merged commit b858891 into cadence-workflow:master Apr 29, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f29c6-715d-47d9-92b5-86ff9cb99dae

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.81%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/parallel_task_processor.go 2 93.06%
service/frontend/api/handler.go 2 62.07%
service/worker/scanner/executor/runq.go 3 85.48%
service/history/task/transfer_standby_task_executor.go 4 86.83%
common/archiver/filestore/historyArchiver.go 4 80.95%
common/task/fifo_task_scheduler.go 4 83.51%
service/frontend/wrappers/metered/metered.go 4 66.67%
service/history/execution/mutable_state_task_refresher.go 14 57.59%
Totals Coverage Status
Change from base Build 018f29c3-80ca-40a3-baef-4ad9f59c38e2: 0.03%
Covered Lines: 99548
Relevant Lines: 146805

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants