Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeouts to prevent flakiness #5953

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

sankari165
Copy link
Member

@sankari165 sankari165 commented Apr 29, 2024

What changed?
Increasing timeouts for activity tasks in testing workflow based internal rate limits

Why?
Activity tasks have been timing out and failing the tests flakily. These tasks are actually ratelimited and retried by history so need to have bigger timeouts configured. The cache works on one second TTL

How did you test it?
Integration tests

Potential risks

Release notes

Documentation Changes

Activity tasks in this test will be ratelimited and thus retried a few times by history service.
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.77%. Comparing base (85f21d9) to head (6308f95).

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f21d9...6308f95. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f2937-b93b-4201-8af4-c9929be0a898

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1568 unchanged lines in 21 files lost coverage.
  • Overall coverage decreased (-0.008%) to 67.779%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/frontend/api/handler.go 2 62.13%
service/history/task/transfer_active_task_executor.go 2 72.72%
common/membership/hashring.go 2 84.69%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
host/taskpoller.go 3 71.94%
service/history/decision/task_handler.go 3 72.33%
service/worker/scanner/executor/runq.go 3 85.48%
Totals Coverage Status
Change from base Build 018f1f09-35ae-4fac-9e3c-30bf2c31a81f: -0.008%
Covered Lines: 99465
Relevant Lines: 146748

💛 - Coveralls

@sankari165 sankari165 merged commit c669c4f into cadence-workflow:master Apr 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants