Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task executor to handle WorkflowAlreadyCompletedError for signal and cancel workflow #5956

Merged
merged 2 commits into from
May 1, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Update task executor to handle WorkflowAlreadyCompletedError for signal and cancel workflow

Why?
To surface correct error message to users

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Apr 29, 2024

Pull Request Test Coverage Report for Build 018f35c3-a953-42ab-893f-195eaa8cfabe

Details

  • 26 of 27 (96.3%) changed or added relevant lines in 2 files are covered.
  • 44 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.01%) to 68.116%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/task/transfer_active_task_executor.go 16 17 94.12%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/task/parallel_task_processor.go 2 93.06%
common/peerprovider/ringpopprovider/config.go 2 81.58%
service/frontend/api/handler.go 2 62.07%
service/history/queue/transfer_queue_processor.go 2 57.05%
service/matching/matcher.go 2 90.72%
common/persistence/historyManager.go 2 66.67%
service/history/task/transfer_standby_task_executor.go 3 86.63%
service/history/task/task.go 3 84.81%
common/persistence/statsComputer.go 3 96.79%
Totals Coverage Status
Change from base Build 018f35ad-8edd-42d8-8be9-df8a2e4323b2: 0.01%
Covered Lines: 100031
Relevant Lines: 146853

💛 - Coveralls

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.95%. Comparing base (d8124b2) to head (178b76e).

Additional details and impacted files
Files Coverage Δ
...history/task/cross_cluster_source_task_executor.go 68.94% <100.00%> (+0.79%) ⬆️
...vice/history/task/transfer_active_task_executor.go 68.80% <85.71%> (+0.13%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8124b2...178b76e. Read the comment docs.

@Shaddoll Shaddoll force-pushed the handle-err branch 3 times, most recently from c60e457 to e99e02f Compare April 30, 2024 17:02
@Shaddoll Shaddoll merged commit d877674 into cadence-workflow:master May 1, 2024
20 checks passed
@Shaddoll Shaddoll deleted the handle-err branch May 1, 2024 21:12
Shaddoll added a commit to Shaddoll/cadence that referenced this pull request May 17, 2024
Shaddoll added a commit that referenced this pull request May 17, 2024
…for signal and cancel workflow (#5956)" (#6026)

This reverts commit d877674.
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants