Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit tests for client/matching/client.go #5959

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

sankari165
Copy link
Member

What changed?
Unit tests for client/matching/client.go
Renamed peerResolver file
Added mocks for peer resolver and load balancer

Why?
Improve unit tests for the code

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.18%. Comparing base (4b2a899) to head (f9a5a04).

Additional details and impacted files
Files Coverage Δ
client/matching/peer_resolver.go 85.18% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2a899...f9a5a04. Read the comment docs.

Copy link
Member

@jakobht jakobht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - added a nit comment

client/matching/client_test.go Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f2eaa-3361-460a-ad32-0c055556257b

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 51 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 67.896%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/matching/taskReader.go 2 83.55%
service/history/shard/context.go 2 68.91%
service/matching/taskListManager.go 2 81.16%
common/task/fifo_task_scheduler.go 3 82.47%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/statsComputer.go 3 96.07%
service/history/execution/mutable_state_task_refresher.go 15 59.81%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018f2bf2-19ab-4010-97e7-e281961bcb92: 0.02%
Covered Lines: 99692
Relevant Lines: 146831

💛 - Coveralls

@sankari165 sankari165 merged commit 95a0c1e into cadence-workflow:master Apr 30, 2024
20 checks passed
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Apr 30, 2024
* Adding unit tests for client/matching/client.go

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants