[code-coverage] Introduced first set of tests for taskHandler in service/history/decision #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsiambaku
force-pushed
the
history-decision
branch
from
1d82618
to
79d97ae
Compare
ketsiambaku
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018f2ef9-362a-478e-9ada-1d35f9bdcb2aDetails
💛 - Coveralls |
dkrotx
approved these changes
Apr 30, 2024
Comment on lines
+98
to
+102
| assert.Equal(t, func(i int32) *types.DecisionTaskFailedCause { | ||
| cause := new(types.DecisionTaskFailedCause) | ||
| *cause = types.DecisionTaskFailedCause(i) | ||
| return cause | ||
| }(9), taskHandler.failDecisionCause) |
There was a problem hiding this comment.
This looks like a trick. Why two assignments are required? And where 9 is coming from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Improve code coverage in service/history/decision folder
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes