Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when set memo in pinot visibility store #5961

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

neil-xie
Copy link
Member

What changed?
Currently it exists memo not equals to nil but data is empty, pinot will save it to search attribute and cause issue when list workflow executions and deserialize

Why?
Bug fix

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.31%. Comparing base (bf088f2) to head (d77430d).

Additional details and impacted files
Files Coverage Δ
common/persistence/pinot/pinot_visibility_store.go 93.23% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf088f2...d77430d. Read the comment docs.

@neil-xie neil-xie enabled auto-merge (squash) April 30, 2024 20:58
@neil-xie neil-xie merged commit ad439b1 into cadence-workflow:master Apr 30, 2024
20 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f30bb-dcf0-4fbe-a31a-33230e9129c8

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 63 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.02%) to 67.915%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/parallel_task_processor.go 2 93.06%
common/persistence/execution_manager.go 2 83.74%
service/matching/db.go 2 73.23%
service/matching/matcher.go 2 90.72%
common/log/tag/tags.go 3 50.46%
service/history/task/fetcher.go 3 85.57%
service/history/queue/timer_queue_processor_base.go 4 77.66%
service/frontend/wrappers/metered/metered.go 4 66.67%
Totals Coverage Status
Change from base Build 018f2f7f-db2f-46d8-b64d-f304962b54b6: -0.02%
Covered Lines: 99721
Relevant Lines: 146831

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants