Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for service/frontend/config/config.go #5968

Merged
merged 1 commit into from
May 7, 2024

Conversation

natemort
Copy link
Member

@natemort natemort commented May 6, 2024

What changed?
Add test coverage for service/frontend/config/config.go

Why?
Increasing test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.00%. Comparing base (abfa99b) to head (15e6082).

❗ Current head 15e6082 differs from pull request most recent head 325c572. Consider uploading reports for the commit 325c572 to get more accurate results

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfa99b...325c572. Read the comment docs.

@natemort natemort merged commit e194e5e into cadence-workflow:master May 7, 2024
16 of 18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f54bf-c1c1-4af2-8c9c-be6601b0f24a

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 75 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.02%) to 68.165%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/handler/handler.go 2 60.71%
service/matching/taskListManager.go 2 80.65%
service/matching/matcher.go 2 90.72%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/statsComputer.go 3 96.07%
service/history/task/fetcher.go 3 86.6%
common/archiver/filestore/historyArchiver.go 4 80.95%
common/task/fifo_task_scheduler.go 5 82.47%
service/history/task/transfer_standby_task_executor.go 6 87.04%
Totals Coverage Status
Change from base Build 018f54af-1427-4fbc-bc5d-7b9472685578: -0.02%
Covered Lines: 100129
Relevant Lines: 146892

💛 - Coveralls

agautam478 pushed a commit to agautam478/cadence that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants