Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for frontend/admin/handler - part 1 #5991

Merged
merged 1 commit into from
May 9, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented May 8, 2024

What changed?
Add more unit test for frontend/admin/handler

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.45%. Comparing base (73e6dbc) to head (04c29e4).
Report is 2 commits behind head on master.

Additional details and impacted files

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e6dbc...04c29e4. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f5a38-f8aa-48fe-92c9-81131e5fabd9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 280 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.1%) to 68.625%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.28%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/fifo_task_scheduler.go 2 85.57%
service/matching/taskListManager.go 2 81.16%
service/matching/matcher.go 2 90.72%
service/history/execution/mutable_state_util.go 2 78.52%
service/history/task/timer_standby_task_executor.go 3 85.63%
service/history/task/transfer_standby_task_executor.go 4 86.83%
service/history/task/fetcher.go 4 85.05%
service/history/engine/engineimpl/history_engine.go 12 82.94%
Totals Coverage Status
Change from base Build 018f59eb-9a95-48c7-ad8f-8dec79b24f38: 0.1%
Covered Lines: 100797
Relevant Lines: 146881

💛 - Coveralls

Copy link
Member

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are really easy to read tests, it's really nice to review

@neil-xie neil-xie merged commit 94b8305 into cadence-workflow:master May 9, 2024
20 checks passed
@neil-xie neil-xie deleted the cdnc_8785 branch May 9, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants