Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for history engine's RefreshWorkflowTasks #5995

Conversation

taylanisikdemir
Copy link
Member

What changed?
Write tests for history engine's RefreshWorkflowTasks

Why?
Improve coverage

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.82%. Comparing base (fad9266) to head (8af21f1).
Report is 4 commits behind head on master.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad9266...8af21f1. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f5b86-d4f3-45c3-9a57-ad88fe968cd8

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 68.684%

Files with Coverage Reduction New Missed Lines %
service/history/shard/context.go 2 68.91%
service/history/task/transfer_active_task_executor.go 2 72.9%
service/matching/matcher.go 2 90.72%
service/history/task/transfer_standby_task_executor.go 4 87.04%
common/task/fifo_task_scheduler.go 4 83.51%
service/history/queue/timer_queue_processor_base.go 4 77.66%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018f5abe-dcfd-41a6-a917-2cc14ce02439: 0.02%
Covered Lines: 100905
Relevant Lines: 146911

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit b4a1f04 into cadence-workflow:master May 9, 2024
22 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/refresh_wf_tasks_tests branch May 9, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants