Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowering threshold for PRs for a one-time refactor/split #5997

Conversation

davidporter-id-au
Copy link
Member

@davidporter-id-au davidporter-id-au commented May 9, 2024

What changed?

This lowers the new diff coverage threshold to 0 for the sake of a refactor/split: #5990. This will be reverted after

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@davidporter-id-au davidporter-id-au marked this pull request as ready for review May 9, 2024 04:53
@davidporter-id-au davidporter-id-au changed the title lowering threshold for PRs lowering threshold for PRs for a one-time refactor/split May 9, 2024
@davidporter-id-au davidporter-id-au enabled auto-merge (squash) May 9, 2024 04:54
@davidporter-id-au davidporter-id-au merged commit 0b71cd9 into cadence-workflow:master May 9, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f5bb2-a0d5-4235-ad9a-e4a6594c4ca6

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 57 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.003%) to 68.694%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.66%
service/matching/taskReader.go 2 84.88%
common/persistence/execution_manager.go 2 83.74%
service/history/task/transfer_active_task_executor.go 2 72.9%
service/history/execution/mutable_state_builder.go 2 71.29%
common/persistence/statsComputer.go 2 96.07%
common/persistence/historyManager.go 2 66.67%
service/history/task/task.go 3 84.81%
service/history/task/timer_active_task_executor.go 3 79.33%
common/asyncworkflow/queue/consumer/default_consumer.go 3 92.13%
Totals Coverage Status
Change from base Build 018f5aff-b7c8-4ac8-9e0c-a14d52f0ae0a: 0.003%
Covered Lines: 100919
Relevant Lines: 146911

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants