-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mutable-state: copy to persistence round-trip test #5998
mutable-state: copy to persistence round-trip test #5998
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018f6049-1c10-4110-977c-bb78c2ea3202Details
💛 - Coveralls |
state.ReplicationState = e.replicationState | ||
state.ExecutionStats = e.executionStats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did the roundtrip test uncover these missed fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
What changed?
Fixes minor bugs in copy method and adds a small round-trip test
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes