Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutable-state: copy to persistence round-trip test #5998

Conversation

davidporter-id-au
Copy link
Member

What changed?
Fixes minor bugs in copy method and adds a small round-trip test

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@davidporter-id-au davidporter-id-au changed the title Refactor/executions splitting out option 2 followup mutable-state: copy to persistence round-trip test May 9, 2024
@davidporter-id-au davidporter-id-au marked this pull request as ready for review May 9, 2024 06:13
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.33%. Comparing base (2fef3c3) to head (1148129).
Report is 3 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
service/history/execution/mutable_state_builder.go 59.85% <100.00%> (+1.22%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fef3c3...1148129. Read the comment docs.

@coveralls
Copy link

coveralls commented May 9, 2024

Pull Request Test Coverage Report for Build 018f6049-1c10-4110-977c-bb78c2ea3202

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 50 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.4%) to 68.45%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
common/membership/hashring.go 2 84.69%
common/persistence/statsComputer.go 3 96.07%
service/frontend/api/handler.go 4 62.26%
service/history/task/fetcher.go 4 86.08%
common/task/fifo_task_scheduler.go 7 82.47%
service/history/engine/engineimpl/poll_mutable_state.go 9 74.16%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018f5e8f-a247-406e-9920-f997ba145d18: -0.4%
Covered Lines: 88018
Relevant Lines: 128588

💛 - Coveralls

Comment on lines +319 to +320
state.ReplicationState = e.replicationState
state.ExecutionStats = e.executionStats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did the roundtrip test uncover these missed fields?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@davidporter-id-au davidporter-id-au enabled auto-merge (squash) May 10, 2024 01:20
@davidporter-id-au davidporter-id-au merged commit 0881452 into cadence-workflow:master May 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants