Add unit test for frontend/admin/handler - part 2 #6003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-xie
requested review from
Shaddoll,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018f6355-2db9-4b66-8eea-28d1e6119fb4Details
💛 - Coveralls |
taylanisikdemir
approved these changes
Jun 4, 2024
| }, | ||
| wantErr: false, | ||
| }, | ||
| "get dql message error": { |
| }, | ||
| }, | ||
| hcHandlerFunc: func(mock *history.MockClient) { | ||
| mock.EXPECT().GetDLQReplicationMessages(gomock.Any(), gomock.Any()).Return(nil, nil) |
There was a problem hiding this comment.
let's return some non-nil object here and validate it's received in test code
| handler.domainDLQHandler = mockDlqHandler | ||
| } | ||
|
|
||
| _, err := handler.ReadDLQMessages(context.Background(), td.input) |
There was a problem hiding this comment.
same here. missing validation of returned messages for success case
| domainDLQHandler: dlqMock, | ||
| } | ||
|
|
||
| _, err := handler.CountDLQMessages(context.Background(), td.input) |
| } | ||
| } | ||
|
|
||
| func Test_GetCrossClusterTasks(t *testing.T) { |
There was a problem hiding this comment.
I think @davidporter-id-au will cleanup cross cluster related code but doesn't hurt to keep these new tests until that happens
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 4, 2024
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 4, 2024
dkrotx
pushed a commit
to dkrotx/cadence
that referenced
this pull request
Jun 5, 2024
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add more unit test for frontend/admin/handler
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes