Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Copy() method to configstore structs #6025

Merged
merged 4 commits into from
Jul 31, 2024
Merged

add Copy() method to configstore structs #6025

merged 4 commits into from
Jul 31, 2024

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
Helper functions copy* are replaced with struct methods

Why?
Better reusability

How did you test it?
Added unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented May 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 01907298-99db-4403-a675-2e4158bcca0f

Details

  • 41 of 41 (100.0%) changed or added relevant lines in 2 files are covered.
  • 41 unchanged lines in 14 files lost coverage.
  • Overall coverage remained the same at 71.522%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/parallel_task_processor.go 2 93.06%
service/matching/tasklist/db.go 2 73.23%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/tasklist/task_writer.go 2 82.21%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 49.64%
service/history/task/timer_standby_task_executor.go 3 85.63%
Totals Coverage Status
Change from base Build 0190705f-c927-4d1b-b54d-772b615f64e2: 0.0%
Covered Lines: 105309
Relevant Lines: 147241
💛 - Coveralls

Shaddoll
Shaddoll reviewed May 22, 2024
View reviewed changes
common/types/configStore_test.go
Copy link
Member

@Shaddoll Shaddoll May 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding tests verifying that changing the copy doesn't affect the original?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea! Will do

@taylanisikdemir taylanisikdemir merged commit fbfe1d4 into cadence-workflow:master Jul 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Shaddoll left review comments

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mantas-sidlauskas @coveralls @taylanisikdemir @Shaddoll