Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common/persistence] Unit tests for SerializeWorkflowSnapshot #6034

Conversation

3vilhamster
Copy link
Member

What changed?
Covered SerializeWorkflowSnapshot function

Why?
Improving code coverage of ExecutionManager.

How did you test it?
Unit tests.

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.09%. Comparing base (02c7efb) to head (f7303b1).
Report is 7 commits behind head on master.

Current head f7303b1 differs from pull request most recent head 7bcae2a

Please upload reports for the commit 7bcae2a to get more accurate results.

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c7efb...7bcae2a. Read the comment docs.

common/persistence/execution_manager_test.go Outdated Show resolved Hide resolved
common/persistence/execution_manager_test.go Outdated Show resolved Hide resolved
common/persistence/execution_manager_test.go Outdated Show resolved Hide resolved
common/persistence/execution_manager_test.go Outdated Show resolved Hide resolved
common/persistence/execution_manager_test.go Outdated Show resolved Hide resolved
common/persistence/execution_manager_test.go Outdated Show resolved Hide resolved
@3vilhamster 3vilhamster enabled auto-merge (squash) May 22, 2024 13:26
@3vilhamster 3vilhamster merged commit c163eef into cadence-workflow:master May 22, 2024
18 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…e-workflow#6034)

* [common/persistence] Unit tests for SerializeWorkflowSnapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants