Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit tests for mutable_state_builder_methods_activity.go #6045

Merged
merged 3 commits into from
May 23, 2024
Merged

Improve unit tests for mutable_state_builder_methods_activity.go #6045

merged 3 commits into from
May 23, 2024

Conversation

sankari165
Copy link
Member

@sankari165 sankari165 commented May 23, 2024 •
edited
Loading

What changed?
More tests and changed one log message that panics while looking up activity info details when not present

Why?
improve code coverage and fix panic cause

How did you test it?
uni tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fa587-14cf-4118-9384-8844543d411b

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 89 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.02%) to 69.331%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/task/parallel_task_processor.go 2 93.06%
common/persistence/execution_manager.go 2 86.43%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/task/fifo_task_scheduler.go 2 87.63%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.72%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/task/fetcher.go 3 85.57%
common/archiver/filestore/historyArchiver.go 4 80.95%
Totals Coverage Status
Change from base Build 018fa464-40c9-4742-b88d-967555b43b81: 0.02%
Covered Lines: 102149
Relevant Lines: 147336
💛 - Coveralls

@sankari165 sankari165 merged commit b785b93 into cadence-workflow:master May 23, 2024
18 checks passed
@sankari165 sankari165 deleted the CDNC-8894 branch May 23, 2024 13:27
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
@sankari165 @timl3136
Improve unit tests for mutable_state_builder_methods_activity.go (cad…
6520956 
…ence-workflow#6045)

* Improve unit tests for mutable_state_builder_methods_activity.go

* Update mutable_state_builder_methods_activity.go

* Update mutable_state_builder_methods_activity_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobht jakobht jakobht approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sankari165 @coveralls @jakobht