Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for history decision task handler #6053

Merged
merged 2 commits into from
May 23, 2024

Conversation

ketsiambaku
Copy link
Member

@ketsiambaku ketsiambaku commented May 23, 2024

What changed?
The following tests added in service/history/decision:
TestHandleDecisionStartTimer
TestHandleDecisionCompleteWorkflow
TestHandleDecisionFailWorkflow

Why?
improve code coverage in the package

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.57%. Comparing base (fb4bfce) to head (1830694).
Report is 2 commits behind head on master.

Additional details and impacted files

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4bfce...1830694. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fa6b3-4bdc-4962-b180-08089f1eee69

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 117 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.008%) to 69.342%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.21%
service/matching/tasklist/db.go 2 73.23%
service/matching/tasklist/task_list_manager.go 2 76.09%
service/matching/tasklist/task_writer.go 2 82.63%
service/history/task/task.go 3 84.81%
common/log/tag/tags.go 3 50.46%
common/task/fifo_task_scheduler.go 3 84.54%
service/history/task/timer_active_task_executor.go 3 79.33%
common/persistence/nosql/nosql_task_store.go 5 63.97%
service/history/execution/cache.go 6 74.61%
Totals Coverage Status
Change from base Build 018fa5a0-da9b-4f76-9263-3511c2f681f9: -0.008%
Covered Lines: 102165
Relevant Lines: 147336

💛 - Coveralls

@ketsiambaku ketsiambaku enabled auto-merge (squash) May 23, 2024 19:04
@ketsiambaku ketsiambaku merged commit b0e1430 into cadence-workflow:master May 23, 2024
20 checks passed
@ketsiambaku ketsiambaku deleted the history-decision branch May 24, 2024 17:56
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
* Add tests for history decision task handler

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants