Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for DeserializeBufferedEvents #6054

Conversation

3vilhamster
Copy link
Member

What changed?
Added unit tests for DeserializeBufferedEvents.

Why?
Improvign test coverage.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fa710-a2c9-4c9c-9f2d-83a07fe2931a

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 199 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.06%) to 69.299%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/matching/tasklist/task_list_manager.go 2 76.09%
common/task/fifo_task_scheduler.go 2 84.54%
service/history/task/transfer_active_task_executor.go 2 72.72%
common/membership/hashring.go 2 84.69%
service/history/task/fetcher.go 2 85.05%
service/matching/tasklist/task_reader.go 4 76.92%
service/history/task/cross_cluster_task_processor.go 8 80.79%
common/persistence/sql/sqlplugin/postgres/db.go 9 65.0%
Totals Coverage Status
Change from base Build 018fa65b-f10a-4dc6-8f5b-50bc0a76f08d: -0.06%
Covered Lines: 102102
Relevant Lines: 147336

💛 - Coveralls

@3vilhamster 3vilhamster merged commit e8111fb into cadence-workflow:master May 24, 2024
18 checks passed
@3vilhamster 3vilhamster deleted the execution-manager-DeserializeBufferedEvents branch May 24, 2024 07:54
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants