Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for mutable_state_builder_methods_decision.go #6055

Conversation

fimanishi
Copy link
Member

What changed?
tests for mutable_state_builder_methods_decision.go

Why?
improve unit test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

What changed?
tests for mutable_state_builder_methods_decision.go

Why?
improve unit test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes
@fimanishi fimanishi force-pushed the tests-for-mutable_state_builder_methods_decision branch from 75b21b6 to b042724 Compare May 23, 2024 21:16
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.99%. Comparing base (02c7efb) to head (5bb5572).
Report is 24 commits behind head on master.

Additional details and impacted files

see 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c7efb...5bb5572. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fac5c-d378-4465-b436-35160dcaea58

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 472 unchanged lines in 28 files lost coverage.
  • Overall coverage decreased (-0.2%) to 69.2%

Files with Coverage Reduction New Missed Lines %
service/history/shard/context.go 1 69.08%
common/persistence/nosql/nosql_visibility_store.go 1 48.78%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/parallel_task_processor.go 2 93.06%
service/matching/tasklist/db.go 2 73.23%
common/dynamicconfig/constants.go 2 99.05%
common/task/fifo_task_scheduler.go 2 85.57%
service/history/task/transfer_active_task_executor.go 2 72.72%
common/util.go 2 91.78%
Totals Coverage Status
Change from base Build 018fa65b-f10a-4dc6-8f5b-50bc0a76f08d: -0.2%
Covered Lines: 101866
Relevant Lines: 147206

💛 - Coveralls

@fimanishi fimanishi merged commit 2f08de5 into cadence-workflow:master May 24, 2024
20 checks passed
@fimanishi fimanishi deleted the tests-for-mutable_state_builder_methods_decision branch May 24, 2024 22:23
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…flow#6055)

* Add tests for mutable_state_builder_methods_decision.go

What changed?
tests for mutable_state_builder_methods_decision.go

Why?
improve unit test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants