Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Put/GetReplicationTasksDLQ #6057

Merged
merged 1 commit into from
May 24, 2024

Conversation

3vilhamster
Copy link
Member

What changed?
Added tests for PutReplicationTaskToDLQ and GetReplicationTasksFromDLQ

Why?
Improving test coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.84%. Comparing base (96c47bc) to head (02be6b3).
Report is 3 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
common/persistence/execution_manager.go 76.02% <100.00%> (+3.79%) ⬆️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c47bc...02be6b3. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018faa28-3da5-4939-b8e4-1fc68b934b9c

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 94 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.02%) to 69.43%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.21%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/db.go 2 73.23%
common/persistence/execution_manager.go 2 86.67%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/task/fifo_task_scheduler.go 2 87.63%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/util.go 2 91.78%
common/persistence/nosql/utils.go 2 60.0%
common/persistence/statsComputer.go 2 97.14%
Totals Coverage Status
Change from base Build 018faa0a-b974-48e9-b632-cc3f5a4155ca: -0.02%
Covered Lines: 102353
Relevant Lines: 147418

💛 - Coveralls

@3vilhamster 3vilhamster merged commit 8fe9988 into cadence-workflow:master May 24, 2024
20 checks passed
@3vilhamster 3vilhamster deleted the dql-tests branch May 24, 2024 13:20
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants