Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-coverage] Add tests for history decision task handler #6061

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

ketsiambaku
Copy link
Member

@ketsiambaku ketsiambaku commented May 26, 2024

What changed?
Introduced the following tests in service/history/decision:

  • TestHandleDecisionContinueAsNewWorkflow
  • TestHandleDecisions
  • TestValidateAttributes

Why?
improve code coverage in the package

How did you test it?

Potential risks

Release notes

Documentation Changes

@ketsiambaku ketsiambaku changed the title Add tests for history decision task handler [code-coverage] Add tests for history decision task handler May 26, 2024
@ketsiambaku ketsiambaku marked this pull request as ready for review May 26, 2024 14:39
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.27%. Comparing base (c6a145d) to head (235ecaf).

Additional details and impacted files

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a145d...235ecaf. Read the comment docs.

@coveralls
Copy link

coveralls commented May 26, 2024

Pull Request Test Coverage Report for Build 018fdae2-5264-4863-b24f-452930f7bd95

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 60 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.01%) to 69.697%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/parallel_task_processor.go 2 93.06%
common/persistence/execution_manager.go 2 90.46%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/replication/task_processor.go 2 81.25%
common/persistence/statsComputer.go 2 98.57%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/historyManager.go 2 66.67%
common/persistence/nosql/nosql_task_store.go 3 85.52%
common/archiver/filestore/historyArchiver.go 4 80.95%
Totals Coverage Status
Change from base Build 018fd17e-a401-4eba-8372-591d1e581574: 0.01%
Covered Lines: 103103
Relevant Lines: 147930

💛 - Coveralls

@ketsiambaku ketsiambaku enabled auto-merge (squash) June 2, 2024 21:40
@ketsiambaku ketsiambaku merged commit e03809a into cadence-workflow:master Jun 2, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…workflow#6061)

Introduce the following tests in service/history/decision:

TestHandleDecisionContinueAsNewWorkflow
TestHandleDecisions
TestValidateAttributes

Use common.Ptr() in decision handler tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants