We now do not log on recent shard closed errors from the getWorkflowExecutionWithRetry function #6068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
…xecutionWithRetry function
jakobht
force-pushed
the
docstore-shard-closed
branch
from
219974c
to
18ad578
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
3vilhamster
reviewed
May 29, 2024
service/history/execution/context.go
Outdated
| // If error is shard closed, only log error if shard has been closed for a while, | ||
| // otherwise always log | ||
| var shardClosedError *shard.ErrShardClosed | ||
| if !errors.As(err, &shardClosedError) || time.Since(shardClosedError.ClosedAt) > shard.TimeBeforeShardClosedIsError { |
There was a problem hiding this comment.
Use timesource here instead of time.Since
3vilhamster
requested changes
May 30, 2024
3vilhamster
approved these changes
May 30, 2024
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 6, 2024
…xecutionWithRetry function (cadence-workflow#6068) * We now do not log on recent shard closed errors from the getWorkflowExecutionWithRetry function * Changed to use timeSource instead of time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now do not log on recent shard closed errors from the getWorkflowExecutionWithRetry function, for other errors we still log all
Why?
Shard closed error are expected for a short time after a shard has been stolen, so there is no reason to do error logs on it for the first short while.
How did you test it?
Unit tests
Potential risks
Minimal only touches logging logic
Release notes
Documentation Changes