Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move err check before log message #6073

Merged

Conversation

sankari165
Copy link
Member

What changed?
Err check moved before log message

Why?
Addressing a nit comment from previous pull request 6065

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.18%. Comparing base (dd54cd0) to head (2efccf5).
Report is 4 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
service/frontend/api/handler.go 40.10% <100.00%> (+0.50%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ef924...2efccf5. Read the comment docs.

@coveralls
Copy link

coveralls commented May 31, 2024

Pull Request Test Coverage Report for Build 018fcefc-1f11-4a84-8d3a-59e490051363

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 70 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.03%) to 69.606%

Files with Coverage Reduction New Missed Lines %
service/frontend/api/handler.go 1 62.44%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/execution_manager.go 2 87.41%
common/task/fifo_task_scheduler.go 2 83.51%
service/history/task/transfer_active_task_executor.go 2 72.79%
common/util.go 2 91.78%
service/matching/tasklist/task_writer.go 2 82.63%
service/matching/tasklist/task_reader.go 2 77.45%
common/persistence/historyManager.go 2 66.67%
common/persistence/nosql/nosql_task_store.go 3 85.52%
Totals Coverage Status
Change from base Build 018fcd8a-6d92-406f-9861-fe59d0f7e5a7: -0.03%
Covered Lines: 102925
Relevant Lines: 147867

💛 - Coveralls

@sankari165 sankari165 merged commit 0aba895 into cadence-workflow:master Jun 3, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-7938-comment-fix branch June 3, 2024 06:52
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
* Move err check before log message

* Update handler.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants