Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CreateWorkflowExecution in execution manager #6075

Conversation

3vilhamster
Copy link
Member

What changed?
Added tests for CreateWorkflowExecution.

Why?
Improving test coverage.

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (eaa93b1) to head (58f750f).

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa93b1...58f750f. Read the comment docs.

@3vilhamster 3vilhamster merged commit 795b1ec into cadence-workflow:master May 31, 2024
20 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fcf10-f72d-40cf-966e-05533b138082

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 63 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.01%) to 69.643%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.94%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/execution_manager.go 2 90.46%
service/matching/tasklist/task_list_manager.go 2 76.09%
common/util.go 2 91.78%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/statsComputer.go 2 98.57%
common/persistence/historyManager.go 2 66.67%
common/task/fifo_task_scheduler.go 3 84.54%
Totals Coverage Status
Change from base Build 018fcea8-93ea-4c40-a2e6-0128d36f1a8b: -0.01%
Covered Lines: 102979
Relevant Lines: 147868

💛 - Coveralls

timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants