Improve TestConcurrentAddAndPoll* tests #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
commented
May 31, 2024
| @@ -740,24 +739,7 @@ func (s *matchingEngineSuite) ConcurrentAddAndPollTasks(taskType int, workerCoun | |||
| s.matchingEngine.config.RangeSize = rangeSize // override to low number for the test | |||
| s.matchingEngine.config.TaskDispatchRPSTTL = time.Nanosecond | |||
| s.matchingEngine.config.MinTaskThrottlingBurstSize = dynamicconfig.GetIntPropertyFilteredByTaskListInfo(_minBurst) | |||
|
|
|||
| mgr, err := tasklist.NewManager( | |||
There was a problem hiding this comment.
this object is not used in the tests at all
taylanisikdemir
approved these changes
May 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Improve TestConcurrentAddAndPoll* tests
Why?
The tests are flaky because the ACKed tasks are not deleted from testTaskManager.
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes