Added tests for metered.go #6083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agautam478
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Jun 3, 2024
|
|
||
| assert.NotNil(t, err) | ||
| assert.Contains(t, err.Error(), "cadence internal error") | ||
| assert.Contains(t, err.Error(), "internal error") |
There was a problem hiding this comment.
this line is redundant given above line
There was a problem hiding this comment.
noted! removing it now and will include the change in second PR
Pull Request Test Coverage Report for Build 018fdf61-ac8e-4492-9f08-45fe4fa188dfDetails
💛 - Coveralls |
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added tests for the 50% of the methods in metered.go
Will push rest of the tests in the upcoming PR.
Why?
code coverage.
How did you test it?
Potential risks
Release notes
Documentation Changes