Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve matching SyncMatch tests #6084

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Jun 3, 2024

What changed?

  • Improve matching SyncMatch tests

Why?
Make the tests more stable

How did you test it?
ran the tests locally 500 times

Potential risks

Release notes

Documentation Changes

@@ -94,7 +94,7 @@ func TestMatchingEngineSuite(t *testing.T) {
}

func (s *matchingEngineSuite) SetupSuite() {
http.Handle("/test/tasks", http.HandlerFunc(s.TasksHandler))
// http.Handle("/test/tasks", http.HandlerFunc(s.TasksHandler))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove if not needed?

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (1463dc5) to head (45346ca).
Report is 1 commits behind head on master.

Additional details and impacted files

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1463dc5...45346ca. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fdfe7-f728-452e-ae9b-c16a1e7d3cf1

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.003%) to 69.695%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.35%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/task/parallel_task_processor.go 2 93.06%
service/matching/tasklist/db.go 2 73.23%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.46%
common/persistence/nosql/nosql_task_store.go 3 85.52%
service/history/task/timer_standby_task_executor.go 3 85.63%
service/history/task/transfer_active_task_executor.go 3 72.79%
Totals Coverage Status
Change from base Build 018fdfdd-be97-4b61-94e9-35bf8e87bec1: -0.003%
Covered Lines: 103104
Relevant Lines: 147936

💛 - Coveralls

@Shaddoll Shaddoll merged commit 4cc5736 into cadence-workflow:master Jun 3, 2024
20 checks passed
@Shaddoll Shaddoll deleted the matching-test branch June 3, 2024 22:00
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants