Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for QueryWorkflow in service/frontend/api/handler.go #6094

Merged

Conversation

fimanishi
Copy link
Member

@fimanishi fimanishi commented Jun 4, 2024

What changed?
tests for QueryWorkflow in service/frontend/api/handler.go

Why?
improve unit test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

**What changed?**
tests for QueryWorkflow in service/frontend/api/handler.go

**Why?**
improve unit test coverage

**How did you test it?**
unit tests

**Potential risks**

**Release notes**

**Documentation Changes**
@coveralls
Copy link

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 018fe405-5695-438b-8798-2532cad3cd06

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 21 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.14%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/backoff/retry.go 1 92.11%
service/history/task/transfer_standby_task_executor.go 2 86.33%
common/task/parallel_task_processor.go 2 93.06%
host/taskpoller.go 2 71.94%
common/util.go 2 91.84%
service/history/task/timer_active_task_executor.go 2 79.33%
service/history/task/task_util.go 2 76.29%
service/history/execution/mutable_state_util.go 2 78.52%
common/membership/hashring.go 2 84.69%
Totals Coverage Status
Change from base Build 018fe3ff-2fc8-4b3a-8126-da4895f07bea: 0.02%
Covered Lines: 104473
Relevant Lines: 148950

💛 - Coveralls

@fimanishi fimanishi merged commit dc2a3a1 into cadence-workflow:master Jun 4, 2024
18 checks passed
@fimanishi fimanishi deleted the tests-for-QueryWorkflow branch June 4, 2024 20:30
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
…ce-workflow#6094)

**What changed?**
tests for QueryWorkflow in service/frontend/api/handler.go

**Why?**
improve unit test coverage

**How did you test it?**
unit tests

**Potential risks**

**Release notes**

**Documentation Changes**
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
…ce-workflow#6094)

**What changed?**
tests for QueryWorkflow in service/frontend/api/handler.go

**Why?**
improve unit test coverage

**How did you test it?**
unit tests

**Potential risks**

**Release notes**

**Documentation Changes**
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Jun 5, 2024
…ce-workflow#6094)

**What changed?**
tests for QueryWorkflow in service/frontend/api/handler.go

**Why?**
improve unit test coverage

**How did you test it?**
unit tests

**Potential risks**

**Release notes**

**Documentation Changes**
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…ce-workflow#6094)

**What changed?**
tests for QueryWorkflow in service/frontend/api/handler.go

**Why?**
improve unit test coverage

**How did you test it?**
unit tests

**Potential risks**

**Release notes**

**Documentation Changes**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants