Fix rebalancing failover tooling #6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What changed?** Excluded `domains` that have `preferredClusters` that are not present in its `cluster` list in `ReplicationConfiguration` **Why?** `Domains` with `preferredClusters` not in their `cluster` list were causing the `workflow` to panic when trying to acquire the `client` for the `preferredCluster` from the `remoteFrontendClients` **How did you test it?** unit tests and local replication tests **Potential risks** The `workflow` was generally not working before because having a `preferredCluster` not in the `domain` `cluster` list is a normal scenario. The risk introduced is the `workflow` actually executing and doing something unexpected. For now, we just rebalance `domains` that have `preferredCluster` set and that can be rebalanced back to their `preferredCluster` **Release notes** **Documentation Changes**
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fimanishi
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
approved these changes
Jun 5, 2024
davidporter-id-au
approved these changes
Jun 5, 2024
davidporter-id-au
approved these changes
Jun 5, 2024
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 6, 2024
**What changed?** Excluded `domains` that have `preferredClusters` that are not present in its `cluster` list in `ReplicationConfiguration` **Why?** `Domains` with `preferredClusters` not in their `cluster` list were causing the `workflow` to panic when trying to acquire the `client` for the `preferredCluster` from the `remoteFrontendClients` **How did you test it?** unit tests and local replication tests **Potential risks** The `workflow` was generally not working before because having a `preferredCluster` not in the `domain` `cluster` list is a normal scenario. The risk introduced is the `workflow` actually executing and doing something unexpected. For now, we just rebalance `domains` that have `preferredCluster` set and that can be rebalanced back to their `preferredCluster` **Release notes** **Documentation Changes**
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 6, 2024
**What changed?** Excluded `domains` that have `preferredClusters` that are not present in its `cluster` list in `ReplicationConfiguration` **Why?** `Domains` with `preferredClusters` not in their `cluster` list were causing the `workflow` to panic when trying to acquire the `client` for the `preferredCluster` from the `remoteFrontendClients` **How did you test it?** unit tests and local replication tests **Potential risks** The `workflow` was generally not working before because having a `preferredCluster` not in the `domain` `cluster` list is a normal scenario. The risk introduced is the `workflow` actually executing and doing something unexpected. For now, we just rebalance `domains` that have `preferredCluster` set and that can be rebalanced back to their `preferredCluster` **Release notes** **Documentation Changes**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Excluded
domainsthat havepreferredClustersthat are not present in itsclusterlist inReplicationConfigurationWhy?
DomainswithpreferredClustersnot in theirclusterlist were causing theworkflowto panic when trying to acquire theclientfor thepreferredClusterfrom theremoteFrontendClientsHow did you test it?
unit tests and local replication tests
Potential risks
The
workflowwas generally not working before because having apreferredClusternot in thedomainclusterlist is a normal scenario. The risk introduced is theworkflowactually executing and doing something unexpected. For now, we just rebalancedomainsthat havepreferredClusterset and that can be rebalanced back to theirpreferredClusterRelease notes
Documentation Changes