Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for methods in frontend api handler #6100

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Add unit tests for methods in frontend api handler #6100

merged 2 commits into from
Jun 5, 2024

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Jun 4, 2024

What changed?
Add unit tests for RespondActivityTaskCanceled and missing lines in RespondActivityTaskFailedByID

Why?
Improve test coverage

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@timl3136 timl3136 enabled auto-merge (squash) June 4, 2024 22:40
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.15%. Comparing base (ab0d875) to head (467bef6).
Report is 10 commits behind head on master.

❗ Current head 467bef6 differs from pull request most recent head df1d0cb

Please upload reports for the commit df1d0cb to get more accurate results.

Additional details and impacted files
Files Coverage Δ
service/frontend/admin/handler.go 83.19% <100.00%> (+25.63%) ⬆️
common/domain/dlq_message_handler.go 94.28% <66.66%> (ø)

... and 19 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0d875...df1d0cb. Read the comment docs.

@timl3136 timl3136 disabled auto-merge June 5, 2024 16:31
@timl3136 timl3136 merged commit d22d81a into cadence-workflow:master Jun 5, 2024
18 checks passed
timl3136 added a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
@timl3136
Add unit tests for methods in frontend api handler (cadence-workflow#…
24746a3 
…6100)

* Add unit tests for RespondActivityTaskCanceled method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timl3136 @taylanisikdemir