Call GetDomainName once in task_list_mngr:NewManager() #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
This makes newTaskListConfig error-less as it should be (since it just produces config)
dkrotx
force-pushed
the
smallfixes-during-deepdive
branch
from
d988604
to
645fda0
Compare
Shaddoll
approved these changes
Jun 5, 2024
Pull Request Test Coverage Report for Build 018fe9f1-e8d5-448d-bef6-0d3f91465651Details
💛 - Coveralls |
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 6, 2024
…low#6107) This makes newTaskListConfig error-less as it should be (since it just produces config)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes newTaskListConfig error-less as it should be (since it just
produces config)
refactoring to make newTaskListConfig return just config, not config & error
small refactoring during deep dive
How did you test it?
Potential risks
Release notes
Documentation Changes