Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed comment during refactoring #6108

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

dkrotx
Copy link
Member

@dkrotx dkrotx commented Jun 5, 2024

Also renamed variable as r looks too short and stands more for reader
or ref rather than response/result.

comment to make more obvious since we talk about "send on closed channel" error here

Refactoring during deep dive session

How did you test it?

Potential risks

Release notes

Documentation Changes

Also renamed variable as `r` looks too short and stands more for reader
or ref rather than response/result.
@dkrotx dkrotx merged commit b25960e into cadence-workflow:master Jun 6, 2024
18 checks passed
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 018fe9e0-42b0-480c-8dab-bca19aed9094

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 151 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.08%) to 70.654%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/backoff/retry.go 2 92.11%
common/task/fifo_task_scheduler.go 2 85.57%
service/history/task/transfer_active_task_executor.go 2 72.77%
common/persistence/historyManager.go 2 66.67%
service/history/task/task.go 3 84.81%
service/matching/tasklist/task_list_manager.go 3 75.89%
bench/lib/client.go 4 0.0%
service/matching/config/config.go 4 91.49%
service/history/task/fetcher.go 4 85.05%
Totals Coverage Status
Change from base Build 018fe9dc-483b-4c68-acea-8033170f8941: -0.08%
Covered Lines: 105240
Relevant Lines: 148951

💛 - Coveralls

timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Also renamed variable as `r` looks too short and stands more for reader
or ref rather than response/result.
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Also renamed variable as `r` looks too short and stands more for reader
or ref rather than response/result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants